
1: Things to do to hash.c: 2: 3: Always use curly braces around statements in if/else/while/do/etc. 4: that span more than a line -- even around multiline simple statements 5: or single-line simple statements preceded by a comment line. 6: 7: Never have lines longer than 80 chars. 8: 9: Remove ^L characters. We don't want/need such crutches. 10: Get a good (smart) pagination filter. I have one (a perl script) 11: that usually does a decent job for me -- I called it something 12: like stdc-print and think I sent you an early verison. 13: 14: I don't like the name `cursor'. I much prefer short names 15: like `p' for index variables. I doubt I'll change all of them, 16: but thought you should know why some will probably end up changing. 17: 18: #define USE_OBSTACK somewhere 19: 20: Fix this comment. Depending on system and application... 21: Mention fragmentation. 22: +#if USE_OBSTACK 23: + /* Whenever obstacks are used, it is possible to allocate all overflowed 24: + entries into a single stack, so they all can be freed in a single 25: + operation. It is not clear if the speedup is worth the trouble. */ 26: + struct obstack entry_stack; 27: +#endif 28: 29: 30: assert (bucket_limit - bucket == n_buckets) ? 31: 32: remove.c: s/done/successful or ok 33: 34: 35: ----- 36: Copyright (C) 1998 Free Software Foundation, Inc. 37: 38: Copying and distribution of this file, with or without 39: modification, are permitted provided the copyright notice 40: and this notice are preserved.